base16_default: add styles to newer unthemed features #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J. Dekker <[email protected]>
Previously virtual text such as LSP inlay was impossible to distinguish from 'real' text by default. Signed-off-by: J. Dekker <[email protected]>
the-mikedavis
approved these changes
Jun 14, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…0858) * base16_default: add `ui.statusline` for `color-modes` Signed-off-by: J. Dekker <[email protected]> * base16_default: add `ui.virtual` default Previously virtual text such as LSP inlay was impossible to distinguish from 'real' text by default. Signed-off-by: J. Dekker <[email protected]> --------- Signed-off-by: J. Dekker <[email protected]>
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
…0858) * base16_default: add `ui.statusline` for `color-modes` Signed-off-by: J. Dekker <[email protected]> * base16_default: add `ui.virtual` default Previously virtual text such as LSP inlay was impossible to distinguish from 'real' text by default. Signed-off-by: J. Dekker <[email protected]> --------- Signed-off-by: J. Dekker <[email protected]>
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
…0858) * base16_default: add `ui.statusline` for `color-modes` Signed-off-by: J. Dekker <[email protected]> * base16_default: add `ui.virtual` default Previously virtual text such as LSP inlay was impossible to distinguish from 'real' text by default. Signed-off-by: J. Dekker <[email protected]> --------- Signed-off-by: J. Dekker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, virtual text such as LSP inlay is impossible to distinguish from 'real' text by default; the
color-modesoption does nothing. I've added a default gray similar to comments (with italics, if supported to more easily distinguish, but we can probably assume that inlay mostly wont be inside comments). Also addedui.statusline.insertto matchdiff.plusandui.statusline.selectto match the selection colour,ui.statusline.normalis intentionally left unthemed.